Discussion:
[Patch, fortran] PR87336] [8/9 regression] wrong output for pointer dummy assiocated to target actual argument
Paul Richard Thomas
2018-09-18 09:37:40 UTC
Permalink
This one came up on clf yesterday. Thanks to Jeurgen Reuter for posting the PR.

This is further fallout from the array descriptor changes. I decided
not to pick out the special case involved but to set the 'span' field
for all new (ie. 'parm') descriptors. A bit of fiddling around with
gfc_get_array_span was needed to punt on incomplete types, unless a
length could be found in the gfc_expr.

Bootstraps and regtests on FC28/x86_64 - OK for 8- and 9-branches?

Paul

2018-09-18 Paul Thomas <***@gcc.gnu.org>

PR fortran/87336
* trans-array.c (gfc_get_array_span): Try to get the element
length of incomplete types. Return NULL_TREE otherwise.
(gfc_conv_expr_descriptor): Only set the 'span' field if the
above does not return NULL_TREE. Set 'span' field if possible
for all new descriptors.

2018-09-18 Paul Thomas <***@gcc.gnu.org>

PR fortran/87336
* gfortran.dg/pointer_array_10.f90 : New test.
* gfortran.dg/assign_10.f90 : Increase 'parm' count to 20.
* gfortran.dg/transpose_optimization_2.f90 : Increase 'parm'
count to 72.
Thomas Koenig
2018-09-18 17:50:40 UTC
Permalink
Hi Paul,
Post by Paul Richard Thomas
Bootstraps and regtests on FC28/x86_64 - OK for 8- and 9-branches?
OK. Thanks for the patch!

Regards

Thomas
Paul Richard Thomas
2018-09-18 17:51:30 UTC
Permalink
Thanks Thomas,

I'll take a look at your in a few minutes.

Cheers

Paul
Post by Thomas Koenig
Hi Paul,
Post by Paul Richard Thomas
Bootstraps and regtests on FC28/x86_64 - OK for 8- and 9-branches?
OK. Thanks for the patch!
Regards
Thomas
--
"If you can't explain it simply, you don't understand it well enough"
- Albert Einstein
Loading...