Discussion:
[PATCH 18/25] Fix interleaving of Fortran stop messages
Toon Moene
2018-09-05 16:57:49 UTC
Permalink
-------- Forwarded Message --------
Subject: [PATCH 18/25] Fix interleaving of Fortran stop messages
Date: Wed, 5 Sep 2018 12:51:19 +0100
From: ***@codesourcery.com
To: gcc-***@gcc.gnu.org


Fortran STOP and ERROR STOP use a different function to print the "STOP"
string
and the message string. On GCN this results in out-of-order output, such as
"<msg>ERROR STOP ".

This patch fixes the problem by making estr_write use the proper Fortran
write,
not C printf, so both parts are now output the same way. This also ensures
that both parts are output to STDERR (not that that means anything on GCN).

2018-09-05 Kwok Cheung Yeung <***@codesourcery.com>

libgfortran/
* runtime/minimal.c (estr_write): Define in terms of write.
---
libgfortran/runtime/minimal.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
Bernhard Reutner-Fischer
2018-09-05 17:15:41 UTC
Permalink
On Wed, 5 Sep 2018 at 18:57, Toon Moene <***@moene.org> wrote:
Right. LGTM but i cannot approve it.

cheers,
Post by Toon Moene
-------- Forwarded Message --------
Subject: [PATCH 18/25] Fix interleaving of Fortran stop messages
Date: Wed, 5 Sep 2018 12:51:19 +0100
Fortran STOP and ERROR STOP use a different function to print the "STOP"
string
and the message string. On GCN this results in out-of-order output, such as
"<msg>ERROR STOP ".
This patch fixes the problem by making estr_write use the proper Fortran
write,
not C printf, so both parts are now output the same way. This also ensures
that both parts are output to STDERR (not that that means anything on GCN).
libgfortran/
* runtime/minimal.c (estr_write): Define in terms of write.
---
libgfortran/runtime/minimal.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
Janne Blomqvist
2018-09-05 18:11:33 UTC
Permalink
Post by Toon Moene
-------- Forwarded Message --------
Subject: [PATCH 18/25] Fix interleaving of Fortran stop messages
Date: Wed, 5 Sep 2018 12:51:19 +0100
Fortran STOP and ERROR STOP use a different function to print the "STOP"
string
and the message string. On GCN this results in out-of-order output, such as
"<msg>ERROR STOP ".
This patch fixes the problem by making estr_write use the proper Fortran
write,
not C printf, so both parts are now output the same way. This also ensures
that both parts are output to STDERR (not that that means anything on GCN).
libgfortran/
* runtime/minimal.c (estr_write): Define in terms of write.
---
libgfortran/runtime/minimal.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
Ok, thanks.
--
Janne Blomqvist
Andrew Stubbs
2018-09-12 13:55:28 UTC
Permalink
Post by Janne Blomqvist
Ok, thanks.
Committed, thanks.

Apologies again for missing the Fortran list.

Andrew

Loading...