Discussion:
[PATCH,FORTRAN] Remove OS dependency in definition of ASYNC_IO
David Edelsohn
2018-08-23 19:03:06 UTC
Permalink
The recent fix for Async I/O on systems without Gthread cond support added
an explicit test for _AIX. This test is unnecessary because
__GTHREAD_HAS_COND is not defined on AIX. Protecting the use of
__gthread_cond_t inside in the ASYNC_IO macro for the declaration of struct
adv_cond is sufficient. This patch simplifies the macro definition.

Bootstrapped on powerpc-ibm-aix7.2.0.0

Okay?

Thanks, David

* async.h (ASYNC_IO): Revert _AIX test.

Index: async.h
===================================================================
--- async.h (revision 263818)
+++ async.h (working copy)
@@ -29,7 +29,7 @@
__gthread_cond_t and __gthread_equal / __gthread_self. Check
this. */

-#if defined(__GTHREAD_HAS_COND) && defined(__GTHREADS_CXX0X) &&
!defined(_AIX)
+#if defined(__GTHREAD_HAS_COND) && defined(__GTHREADS_CXX0X)
#define ASYNC_IO 1
#else
#define ASYNC_IO 0
Thomas Koenig
2018-08-23 19:27:24 UTC
Permalink
David,
Post by David Edelsohn
The recent fix for Async I/O on systems without Gthread cond support added
an explicit test for _AIX. This test is unnecessary because
__GTHREAD_HAS_COND is not defined on AIX. Protecting the use of
__gthread_cond_t inside in the ASYNC_IO macro for the declaration of struct
adv_cond is sufficient. This patch simplifies the macro definition.
Bootstrapped on powerpc-ibm-aix7.2.0.0
Okay?
OK.

Thanks for the patch!

Thomas

Loading...