[Patch, fortran] PR87566 - ICE with class(*) and select

[Paul Richard Thomas]

Tobias started this patch and I finished it in answering a question
that he had about a problem with the gimplifier. Along the way, I
tried the associate version of the select type test case and found
that it failed in a different way. The chunk in resolve_assoc_var
fixes that.

Bootstrapped and regtested on FC28/x86_64 - OK for trunk?

On checking to see if any other associate problems had been fixed, I
noticed, as had Dominique, that PR83146 was fixed. I committed the
testcase to trunk as revision 265148 to make sure that it remained so.

Paul

2018-10-14 Paul Thomas <***@gcc.gnu.org>
Tobias Burnus <***@gcc.gnu.org>

PR fortran/87566
* resolve.c (resolve_assoc_var): Add missing array spec for
class associate names.
(resolve_select_type): Handle case where last typed component
of the selector has a different type to the expression.
* trans-expr.c (gfc_find_and_cut_at_last_class_ref): Replace
call to gfc_expr_to_initialize with call to gfc_copy_expr.
(gfc_conv_class_to_class): Guard assignment to 'len' field
against case where zero constant is supplied.

2018-10-14 Paul Thomas <***@gcc.gnu.org>
Tobias Burnus <***@gcc.gnu.org>

PR fortran/87566
* gfortran.dg/select_type_44.f90: New test.
* gfortran.dg/associate_42.f90: New test.

[Dominique d'Humières]

Hi Paul,

The ICEs for the following PRs 58906, a variant of 77385, 80260, and 82077, have been fixed between revision r264941 + patches and r265126 + same patches + this patch + patch for pr56386.

Cheers,

Dominique

[Paul Richard Thomas]

Hi Dominique,

The ICEs for the following PRs 58906, a variant of 77385, 80260, and 82077, have been fixed between revision r264941 + patches >>> (which patches?)

and r265126 + same patches >>> (ditto)
+ this patch + patch for pr56386.

Thanks for doing all this checking. It is a huge contribution.

Regards

Paul

[Dominique d'Humières]

Post by Paul Richard Thomas
Hi Dominique,

The ICEs for the following PRs 58906, a variant of 77385, 80260, and 82077, have been fixed between revision r264941 + patches >>> (which patches?)

Mostly patches for darwin + wip.

Post by Paul Richard Thomas
and r265126 + same patches >>> (ditto)
+ this patch + patch for pr56386.

Actually these PRs have been fixed (at least the ICEs) by this patch (tested on a cleaner build).

Thanks for the work.

Dominique

Post by Paul Richard Thomas
Thanks for doing all this checking. It is a huge contribution.
Regards
Paul

[Paul Richard Thomas]

Hi Dominique,

I now understand what you mean about the patches and confirm what you
say about the fixes. In fact, the original of PR77385 seems to be
fixed as well.

I will sort out which of the testcases needs to be included in the
testsuite - ie. which ones have exclusive features. I will submit to
the list, when this si done.

Many thanks, once again.

Paul

Post by Dominique d'Humières
Hi Paul,
The ICEs for the following PRs 58906, a variant of 77385, 80260, and 82077, have been fixed between revision r264941 + patches and r265126 + same patches + this patch + patch for pr56386.
Cheers,
Dominique

[Thomas Koenig]

Hi Paul,

Post by Paul Richard Thomas
Bootstrapped and regtested on FC28/x86_64 - OK for trunk?

Looks good. Thanks!

Regards

Thomas

[Paul Richard Thomas]

Committed as revision 265171.

Thanks to you, Dominique and, of course, Tobias.

Paul

Post by Dominique d'Humières
Hi Paul,

Post by Paul Richard Thomas
Bootstrapped and regtested on FC28/x86_64 - OK for trunk?

Looks good. Thanks!
Regards
Thomas